Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add errors/stacks to dart:developer logging #1869

Merged
merged 1 commit into from
Jul 18, 2019
Merged

Conversation

DanTup
Copy link
Member

@DanTup DanTup commented Jul 17, 2019

I originally missed these out. They're also async, so we need to chain future logs after this to ensure they're printed in the same order.

Screenshot 2019-07-17 at 10 53 36 am

Fixes #1824.

@DanTup DanTup added is enhancement in debugger Relates to the debug adapter or process of launching a debug session labels Jul 17, 2019
@DanTup DanTup added this to the v3.3.0 milestone Jul 17, 2019
@DanTup
Copy link
Member Author

DanTup commented Jul 17, 2019

@devoncarew in the screenshot above, the exception text says <collected>. This seems to be what comes back from the VM when I call toString() on the exception. Is there anything we can do to avoid this? (it doesn't seem consistent, but it seems to happen almost every time).

@DanTup DanTup force-pushed the dart-dev-log-improvements branch from cb6457a to 648c0e4 Compare July 17, 2019 10:05
@DanTup DanTup force-pushed the dart-dev-log-improvements branch from 648c0e4 to 26cc3c5 Compare July 17, 2019 10:06
@DanTup DanTup merged commit d7264d1 into master Jul 18, 2019
@DanTup DanTup deleted the dart-dev-log-improvements branch July 18, 2019 15:54
@devoncarew
Copy link
Contributor

This seems to be what comes back from the VM when I call toString() on the exception. Is there anything we can do to avoid this? (it doesn't seem consistent, but it seems to happen almost every time).

I don't know that there's anything we can do on the client side. cc @bkonyi; something to consider - when object refs are sent to clients, we may want some brief grace period before they can be considered for collection. A ring buffer of the last n objects sent to the client? Have objects flushed from a buffer after some short duration in the buffer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Switch to structured logs from dart:developer log()
2 participants