Extend analysis to to custom file extensions; folding for non-Dart files #2022
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To better support analyzer plugins on custom file endings, I've made two changes:
MODE_HTML
) for extensions declared inadditionalAnalyzerFileExtensions
if the option to use the Angular plugin is turned on.With a plugin I'm writing, I could verify that auto-complete, folding, outline, problems, fixes and navigation are all working with this setup.
Fixes #1981
Potential problems
In the linked issue, you asked whether the analysis server would send problematic responses when used with unsupported files. I played around with this as the plugin was turned off, and I didn't run into any problems.
Further, that shouldn't have any impact on the first change because it only effects users who explicitly added a file to
additionalAnalyzerFileExtensions
, which only makes sense when an appropriate plugin is available.