Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to GitHub Actions for CI builds #2157

Merged
merged 27 commits into from Dec 9, 2019
Merged

Switch to GitHub Actions for CI builds #2157

merged 27 commits into from Dec 9, 2019

Conversation

DanTup
Copy link
Member

@DanTup DanTup commented Dec 9, 2019

No description provided.

These tests are only testing the resolution, but were running full apps (which are ~20s) for no real reason.
We ran this test 3 times to check after 0, 1, 2 breakpoints - however each test effectively included the previous. Running just the last one gives the same coverage but removes ~40s out of the ~60s to run the three.
This test was designed to catch the difference between original source, and source after a reload. Two reloads shouldn't be any different to one (but makes the test a fair bit longer - especially for web).
Revisit this once there's a response or fix to microsoft/vscode#86403.
Trying to track down intermittent issue where on Windows the sandbox doesn't seem to be intercepting the calls to the dart.getPackages command in pub_get_runs_automatically_when_pubspec_is_saved.
@DanTup DanTup added the is testing Relates to the testing (either manual or automated) of Dart Code label Dec 9, 2019
@DanTup DanTup added this to the v3.8.0 milestone Dec 9, 2019
@DanTup DanTup merged commit 98efbaf into master Dec 9, 2019
@DanTup DanTup deleted the gh-actions-test branch December 9, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
is testing Relates to the testing (either manual or automated) of Dart Code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant