Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Create Offline Configuration #2311

Merged
merged 1 commit into from Mar 30, 2020

Conversation

ejabu
Copy link
Contributor

@ejabu ejabu commented Mar 23, 2020

Fixes #1957.

@ejabu
Copy link
Contributor Author

ejabu commented Mar 23, 2020

Issues :

#1957

Copy link
Member

@DanTup DanTup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this! I added some minor comments, but otherwise it looks good. Thanks!

Comment on lines +216 to +218
if (config.flutterCreateOffline) {
args.push("--offline");
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like this argument might be being added twice?

@@ -67,6 +67,7 @@ class Config {
get flutterAndroidX(): boolean { return this.getConfig<boolean>("flutterAndroidX", false); }
get flutterCreateAndroidLanguage(): "java" | "kotlin" { return this.getConfig<"java" | "kotlin">("flutterCreateAndroidLanguage", "kotlin"); }
get flutterCreateIOSLanguage(): "objc" | "swift" { return this.getConfig<"objc" | "swift">("flutterCreateIOSLanguage", "swift"); }
get flutterCreateOffline(): boolean { return this.getConfig<boolean>("flutterCreateOffline", true); }
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This true should be false (it should match the default value).

"dart.flutterCreateOffline": {
"type": "boolean",
"default": false,
"description": "Whether to create new flutter project using offline mode",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Should end with full stop to match the others.

@DanTup DanTup added this to the v3.9.0 milestone Mar 26, 2020
@DanTup DanTup added in flutter Relates to running Flutter apps is enhancement in commands Relates to commands (usually invoked from the command Palette) labels Mar 26, 2020
@DanTup
Copy link
Member

DanTup commented Mar 30, 2020

I'm planning on a beta release shortly, so I'll merge this and tidy up the small things mentioned above. Thanks!

@DanTup DanTup merged commit 3ee2f4c into Dart-Code:master Mar 30, 2020
@ejabu
Copy link
Contributor Author

ejabu commented Mar 30, 2020

I'm planning on a beta release shortly, so I'll merge this and tidy up the small things mentioned above. Thanks!

sorry got no change of working it, kinda busy setting up new laptop.

thanks by the way for merging it !

@DanTup
Copy link
Member

DanTup commented Mar 30, 2020

No worries - I merged it and made those tweaks. It's in the beta I released today:

https://github.com/Dart-Code/Dart-Code/releases/tag/v3.9.0-beta.1

And will ship in the stable release (aiming for end of this week). Thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in commands Relates to commands (usually invoked from the command Palette) in flutter Relates to running Flutter apps is enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to use Flutter: New Project offline
2 participants