Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch dart.progress for DAP progress events #2540

Merged
merged 3 commits into from
Jun 17, 2020
Merged

Switch dart.progress for DAP progress events #2540

merged 3 commits into from
Jun 17, 2020

Conversation

BootBlock
Copy link
Contributor

Fixes #2516.

@DanTup
Copy link
Member

DanTup commented Jun 17, 2020

Thanks! I caused some conflicts with this, so I've rebased your branch over master and fixed up.

I also changed this to pass an empty title:

this.sendEvent(new ProgressStartEvent(debugLaunchProgressId, "", "Launching..."));

It's not clear if this is allowed (the spec says title is mandatory), but I've filed microsoft/language-server-protocol#1025 for clarification. If it's not allowed, I think there should be a way to allow us to have single-message updatable progress without needing to have two messages joined with colons.

@DanTup DanTup added this to the v3.12.0 milestone Jun 17, 2020
@DanTup DanTup added in debugger Relates to the debug adapter or process of launching a debug session is enhancement labels Jun 17, 2020
@DanTup DanTup merged commit c4b51c4 into Dart-Code:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in debugger Relates to the debug adapter or process of launching a debug session is enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate dart.progress events to use DAP's progressEvent
2 participants