Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop Flutter UI guidelines being tilted for certain fonts #2870

Merged
merged 2 commits into from
Oct 12, 2020
Merged

Stop Flutter UI guidelines being tilted for certain fonts #2870

merged 2 commits into from
Oct 12, 2020

Conversation

BootBlock
Copy link
Contributor

Fixes the tilting, but there may be a visual artifact due to the guidelines vertically overlapping (see included screenshot).

image

Fixes #2239.

Copy link
Member

@DanTup DanTup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though has a lint failure:

The key 'fontStyle' is not sorted alphabetically (tslint:object-literal-sort-keys)

@DanTup DanTup merged commit 5dbab1d into Dart-Code:master Oct 12, 2020
@DanTup DanTup added this to the v3.16.0 milestone Oct 12, 2020
@DanTup DanTup added in editor Relates to code editing or language features in flutter Relates to running Flutter apps is bug fix labels Oct 12, 2020
@DanTup DanTup requested review from DanTup and removed request for DanTup October 12, 2020 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features in flutter Relates to running Flutter apps is bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Indicator Lines get Tilted when using /**/ type comments when using SynthWave84 Theme and Fira Code Font
2 participants