Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prefilled project name #2994

Merged
merged 4 commits into from Dec 8, 2020
Merged

Prefilled project name #2994

merged 4 commits into from Dec 8, 2020

Conversation

BootBlock
Copy link
Contributor

  • Pre-fills name upon creating a new project. Project name determination only occurs for the initial, pre-filled name suggestion and will not apply if a different name is entered entirely.

  • Displays an in-place error during (user input) project naming should a directory with the specified name already exist. This negates the user needing to reinvoke the create-project command to begin creating a project again.

  • Optimises out multiple fsPath() calls.

BootBlock and others added 4 commits December 7, 2020 14:35
Now asks for the project folder first, so it can determine a unique project name for creation should the pre-filled name be accepted within the corresponding dialog.

Project name determination only occurs for the initial, pre-filled name suggestion and will not apply if a different name is entered entirely.

Fixes #2989.
Project name pre-filling now always ends in a number (eg. `my_project_1`, `my_project_2`) rather than using a file copy duplication style (eg. `my_project`, `my_project_1`).

In-place error during project naming should a directory with the specified name already exist. This negates the need of having to reinvoke the  create project command to begin creating a project again.
Replaces multiple fsPath() calls with a variable counterpart.
@DanTup DanTup self-requested a review December 8, 2020 15:58
@DanTup DanTup added this to the v3.18.0 milestone Dec 8, 2020
@DanTup DanTup added in commands Relates to commands (usually invoked from the command Palette) is enhancement labels Dec 8, 2020
@DanTup DanTup merged commit a4e2b08 into Dart-Code:master Dec 8, 2020
@BootBlock BootBlock deleted the prefilled-project-name branch December 8, 2020 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in commands Relates to commands (usually invoked from the command Palette) is enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants