Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude .dart_tool folder from upgrade packages list #3014

Merged
merged 4 commits into from Dec 17, 2020
Merged

Exclude .dart_tool folder from upgrade packages list #3014

merged 4 commits into from Dec 17, 2020

Conversation

BootBlock
Copy link
Contributor

Prevents the .dart_tool folder from appearing within the Flutter: Upgrade Packages list.

Fixes #3013.

Prevents the `.dart_tool` folder from appearing within the **Flutter: Upgrade Packages** list.

Fixes #3013.
@@ -101,7 +101,7 @@ export async function findProjectFolders(logger: Logger, roots: string[], exclud
}));
const projectFoldersChecks = await Promise.all(projectFolderPromises);
const projectFolders = projectFoldersChecks
.filter((res) => res.exists)
.filter((res) => res.exists && !res.folder.includes(".dart_tool"))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably more this to the filter on line 94 (or an additional line next to it) to avoid the hasPubspec etc. checks on folders we'd then discard anyway.

We should also probably also put ${path.sep} on each end just to ensure we only get folders with exactly that segment.

@DanTup DanTup added in commands Relates to commands (usually invoked from the command Palette) is bug fix labels Dec 17, 2020
@DanTup DanTup added this to the v3.18.0 milestone Dec 17, 2020
@DanTup DanTup merged commit 8e4d414 into Dart-Code:master Dec 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in commands Relates to commands (usually invoked from the command Palette) is bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.dart_tool folder shows up in package list
2 participants