Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract devtools links from flutter structured errors #3087

Merged

Conversation

DanTup
Copy link
Member

@DanTup DanTup commented Jan 21, 2021

  • Rebase over Share DevTools server with Flutter #3086
  • Replace link in console output with a not saying to look for the notification
  • Ensure we only display one notification at a time
  • See if we can improve the regex to be less reliant on the exact text

@DanTup DanTup added is enhancement in flutter Relates to running Flutter apps in commands Relates to commands (usually invoked from the command Palette) labels Jan 21, 2021
@DanTup DanTup added this to the On Deck milestone Jan 21, 2021
@DanTup DanTup force-pushed the extract-devtools-links-from-flutter-structured-errors branch from 9bc9600 to 631b05e Compare January 26, 2021 10:24
@DanTup DanTup modified the milestones: On Deck, v3.19.0 Jan 26, 2021
@DanTup DanTup force-pushed the extract-devtools-links-from-flutter-structured-errors branch from 631b05e to 9e81789 Compare January 27, 2021 10:42
@DanTup DanTup changed the title WIP: Extract devtools links from flutter structured errors Extract devtools links from flutter structured errors Jan 27, 2021
@DanTup DanTup force-pushed the extract-devtools-links-from-flutter-structured-errors branch from 9e81789 to 71ab22a Compare January 27, 2021 10:51
@DanTup DanTup marked this pull request as ready for review January 27, 2021 10:51
@DanTup DanTup merged commit aca47e0 into master Jan 27, 2021
@DanTup DanTup deleted the extract-devtools-links-from-flutter-structured-errors branch January 27, 2021 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in commands Relates to commands (usually invoked from the command Palette) in flutter Relates to running Flutter apps is enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant