Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce the amount of Snap-specific code requires to set up Flutter #3292

merged 2 commits into from Apr 26, 2021


Copy link

@DanTup DanTup commented Apr 21, 2021

Fixes #2853.

@MarcusTomlinson FYI - this is to remove a lot of the snap-specific code that should no longer be required (canonical/flutter-snap#8).

There is still a little code to detect where a user has never invoked flutter so it hasn't been initialised, which is in the block here:

It detects when no Flutter SDK is found, but there is a flutter binary that is a symlink to the Snap binary (it seems like this is created by Snap initially, so that the first run of flutter will trigger the initialisation), forces initialisation, and then re-searches for the SDK (since after initialisation, there is a new flutter binary on PATH that is a real SDK - the original Snap-symlink seems to remain, further down the PATH).

Unless you have any objections, I'll merge this early next week. The tests that confirm it's located and initialised are still green when they ran on this branch.

@DanTup DanTup merged commit 195b1c6 into master Apr 26, 2021
@DanTup DanTup deleted the remove-snap-specific-code branch April 26, 2021 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

Simplify Snap support once environment changes land in beta/stable
1 participant