Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support launching emulator devices in remote workspaces #3352

Merged
merged 1 commit into from
May 19, 2021
Merged

Support launching emulator devices in remote workspaces #3352

merged 1 commit into from
May 19, 2021

Conversation

Delgan
Copy link
Contributor

@Delgan Delgan commented May 18, 2021

Hey @DanTup.

I just saw your fix for #3315. Thanks for that!

I also noticed the "Launch Emulator" command wasn't available in remote workspace. I guess this is because of the when clause in "package.json":

Dart-Code/package.json

Lines 987 to 988 in f38e02c

"command": "flutter.launchEmulator",
"when": "dart-code:anyFlutterProjectLoaded && dart-code:isRunningLocally"

I supposed this simple additional condition using the new configuration parameter would allow to run the command in a devcontainer.

Thoughts?

@DanTup DanTup added this to the v3.23.0 milestone May 19, 2021
@DanTup DanTup added in flutter Relates to running Flutter apps is enhancement labels May 19, 2021
@DanTup
Copy link
Member

DanTup commented May 19, 2021

Good spot, thanks!

@DanTup DanTup merged commit 00d8264 into Dart-Code:master May 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in flutter Relates to running Flutter apps is enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants