Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: add return type of main #3589

Merged
merged 1 commit into from
Oct 5, 2021
Merged

style: add return type of main #3589

merged 1 commit into from
Oct 5, 2021

Conversation

Ascenio
Copy link
Contributor

@Ascenio Ascenio commented Oct 4, 2021

This could be subjective, but I think it's good to have a return type on every function. Every time I use the main snippet I find myself writing void anyway. You could also argue that I could make my own snippet, and that's true. But because dart is typed after all and fun uses void, why not?

@DanTup DanTup added this to the v3.28.0 milestone Oct 4, 2021
@DanTup DanTup added in editor Relates to code editing or language features is enhancement labels Oct 4, 2021
@Ascenio
Copy link
Contributor Author

Ascenio commented Oct 4, 2021

I think there's something funny going on with tests.

@DanTup
Copy link
Member

DanTup commented Oct 5, 2021

Thanks!

I don't believe either of the test failures are related to this. One is a known problem and the other looks like the SDK update check got a status 200 but not valid JSON and didn't handle that correctly. I'll improve the handling of that on the main branch.

@DanTup DanTup merged commit 0ac815d into Dart-Code:master Oct 5, 2021
@Ascenio Ascenio deleted the patch-1 branch October 5, 2021 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in editor Relates to code editing or language features is enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants