Call super.dispose() at the end of dispose() in stanim snippet
#3965
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! With newer versions of the extension/SDKs, the snippets come from the server so I've applied the same fix there at https://dart-review.googlesource.com/c/sdk/+/245003/. |
DanTup
added
is bug fix
in flutter
|
Great, thanks! |
copybara-service bot
pushed a commit
to dart-lang/sdk
that referenced
this pull request
May 17, 2022
…pose method Equiv change for extension-shipped snippet in Dart-Code/Dart-Code#3965. Change-Id: Ief61a7d11f19edac6f4f4a14f311d7789add8d80 Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/245003 Reviewed-by: Brian Wilkerson <brianwilkerson@google.com> Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From the Flutter docs of the dispose method:
Therefore, we should call
super.dispose()at the end.