Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infer a default CWD for workspaces with multiple folders if they have a common ancestor #4178

Merged
merged 1 commit into from
Sep 26, 2022
Merged

Infer a default CWD for workspaces with multiple folders if they have a common ancestor #4178

merged 1 commit into from
Sep 26, 2022

Conversation

DanTup
Copy link
Member

@DanTup DanTup commented Sep 26, 2022

@helin24 can you verify this works for your case?

@DanTup DanTup requested a review from helin24 September 26, 2022 16:32
@DanTup DanTup added this to the v3.50.0 milestone Sep 26, 2022
helin24
helin24 approved these changes Sep 26, 2022
View reviewed changes
Copy link
Contributor

@helin24 helin24 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This works for my cases! Thanks!

@DanTup DanTup merged commit 84a8a45 into master Sep 26, 2022
@DanTup DanTup deleted the infer-cwd-from-workspace-folders branch September 26, 2022 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@helin24 helin24 helin24 approved these changes

Assignees
No one assigned
Labels
is enhancement
Projects
None yet
Milestone
v3.50.0
Development

Successfully merging this pull request may close these issues.
2 participants
@DanTup @helin24