Add support for new DAP toolEvents #4337
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanTup
added
is bug fix
in debugger
|
Can this be landed now? |
|
Technically, yes - but it won't work until the new DDS is rolled into Flutter (which I think is blocked on some other dependencies like dwds being compatible with vm_service 10). I was waiting for that to be done just so I could do a final test with everything landed (since previous testing was done using dependency_overrides etc.). |
|
Scratch that, DDS was already rolled to the required version (I thought it was blocked based on flutter/flutter#118414). I'll publishing a release shortly, so I'll do that first, then land this before pushing a pre-release. I don't want to merge this in right before the release (and it will only work for those on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will only work once flutter/flutter#118098 has landed and DDS >= 2.7.2 rolls into Flutter.
The old DAP is not being updated but will continue to use the old
inspect()event (which is still being sent for compatibility).Fixes #4193.