Skip to content

Add support for running tests by line number instead of name #4487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Apr 19, 2023

Conversation

DanTup
Copy link
Member

@DanTup DanTup commented Apr 5, 2023

See #4021.

  • Address // TODO(dantup): This is right for Flutter, but must check package:test version for Dart too!
  • Remove const runTestsByLine = true
  • Address // TODO(dantup): Ensure we don't get here for Dart SDK or Bazel where we shouldn't use "dart run"?
  • Address // TODO(dantup): WIRE THIS UP!
  • Review if findMatchingDynamicNode should be taking lines into account?
  • Ensure there are tests that cover multiple tests in one run ("program": "foo_test.dart?line=1", "args": ["foo_test.dart?line=20"])
    • manually tested
  • Test all issues noted/referenced in Run tests using line/col to support groups/test with dynamic names #4021
  • Address // TODO(dantup): Ensure this never runs in the SDK, because it may produce unwanted package_configs?
  • Revert setting the default to "line" that was used for testing on the bots (c00add9)
  • Ensure Flutter has automated tests in the same way as Dart
    • manually tested

Fixes several issues:

@DanTup DanTup added is enhancement in testing Relates to test execution of Dart/Flutter tests for end users labels Apr 5, 2023
@DanTup DanTup added this to the v3.64.0 milestone Apr 5, 2023
@DanTup DanTup force-pushed the run-tests-by-line branch 4 times, most recently from 11ecd70 to c00add9 Compare April 18, 2023 17:15
@DanTup DanTup force-pushed the run-tests-by-line branch from ba4a0ee to f4f0fd7 Compare April 19, 2023 11:02
@DanTup DanTup changed the title Add some basic support for running tests by line number instead of name Add support for running tests by line number instead of name Apr 19, 2023
@DanTup DanTup merged commit e02dea9 into master Apr 19, 2023
@DanTup DanTup deleted the run-tests-by-line branch April 19, 2023 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
in testing Relates to test execution of Dart/Flutter tests for end users is enhancement
Projects
None yet
2 participants