-
Notifications
You must be signed in to change notification settings - Fork 324
Add support for running tests by line number instead of name #4487
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11ecd70
to
c00add9
Compare
…cy in the hello_world sample project
ba4a0ee
to
f4f0fd7
Compare
DanTup
commented
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #4021.
// TODO(dantup): This is right for Flutter, but must check package:test version for Dart too!
const runTestsByLine = true
// TODO(dantup): Ensure we don't get here for Dart SDK or Bazel where we shouldn't use "dart run"?
// TODO(dantup): WIRE THIS UP!
findMatchingDynamicNode
should be taking lines into account?"program": "foo_test.dart?line=1", "args": ["foo_test.dart?line=20"]
)// TODO(dantup): Ensure this never runs in the SDK, because it may produce unwanted package_configs?
Fixes several issues: