From 51b60f1257e35a5ec57fb8c2d4c48d858c580558 Mon Sep 17 00:00:00 2001 From: Robert Biro Date: Mon, 5 Sep 2016 14:01:31 +0100 Subject: [PATCH] Make .remove chainable --- mangler.js | 7 ++----- test/test.js | 14 +++++--------- 2 files changed, 7 insertions(+), 14 deletions(-) diff --git a/mangler.js b/mangler.js index c3c9e5f..3086379 100644 --- a/mangler.js +++ b/mangler.js @@ -1127,11 +1127,8 @@ var Mangler = (function(global) { remove: function(item) { var i = this.items.indexOf(item); - if(i > -1) { - this.items.splice(i, 1); - return true; - } - return false; + if(i > -1) this.items.splice(i, 1); + return this; }, rename: function(dict) { diff --git a/test/test.js b/test/test.js index db56af7..0758964 100644 --- a/test/test.js +++ b/test/test.js @@ -1206,18 +1206,14 @@ }); QUnit.test('.remove', function(assert) { - assert.expect(8); + assert.expect(4); var m = Mangler(['A', 'B', 'C']); - assert.strictEqual(m.remove('B'), true, 'passed'); - assert.deepEqual(m.items, ['A', 'C'], 'passed'); - assert.strictEqual(m.remove('D'), false, 'passed'); - assert.deepEqual(m.items, ['A', 'C'], 'passed'); - assert.strictEqual(m.remove('A'), true, 'passed'); - assert.deepEqual(m.items, ['C'], 'passed'); - assert.strictEqual(m.remove('C'), true, 'passed'); - assert.deepEqual(m.items, [], 'passed'); + assert.deepEqual(m.remove('B').items, ['A', 'C'], 'passed'); + assert.deepEqual(m.remove('D').items, ['A', 'C'], 'passed'); + assert.deepEqual(m.remove('A').items, ['C'], 'passed'); + assert.deepEqual(m.remove('C').items, [], 'passed'); }); QUnit.test('.rename', function(assert) {