New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for logging errors to Sentry #125

Closed
koenpunt opened this Issue Jan 7, 2019 · 2 comments

Comments

2 participants
@koenpunt
Copy link
Contributor

koenpunt commented Jan 7, 2019

As an alternative to New Relic it would be nice to also support Sentry.

I could take a stab at implementing this, but I'm not that experienced with Go, and I currently probably don't have time for it..

Documentation: https://docs.sentry.io/clients/go/

@DarthSim

This comment has been minimized.

Copy link
Owner

DarthSim commented Jan 10, 2019

Hi!

There shouldn't be much of work and it's a good chance to get some Go experience :) All errors reporting is done here https://github.com/DarthSim/imgproxy/blob/master/errors_reporting.go. If you could find some time for implementing this, I would really appreciate this.

@koenpunt

This comment has been minimized.

Copy link
Contributor

koenpunt commented Jan 11, 2019

I'm looking into it now, and I have a question; The Sentry client already supports setup using environment variables (when the library is included a default client is created using them), but I'm not sure if we want to rely on that from within imgproxy, or that I should create a dedicated client, and pass in configuration from the imgproxy config. WDYT?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment