New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add provides to META.yml #23

Closed
wants to merge 1 commit into
base: master
from

Conversation

Projects
None yet
2 participants
@jmaslak

jmaslak commented Feb 27, 2016

Howdy, I got your module this month as part of the CPAN Pull Request Challenge. It looked like you're following good practices pretty consistently, so I didn't see a lot of room for improvement. This is a trivial change to have Dist::Zilla create the "provides" section in the META.yml ( http://search.cpan.org/~dagolden/CPAN-Meta-2.150005/lib/CPAN/Meta/Spec.pm#provides ). Note it needs the Dist::Zilla::Plugin::MetaProvides package to be installed to successfully "dzil build".

@DarwinAwardWinner

This comment has been minimized.

Show comment
Hide comment
@DarwinAwardWinner

DarwinAwardWinner Feb 28, 2016

Owner

If this addition to dist.ini is something that should pretty much be in every module, it would probably make more sense to add it to my plugin bundle here: https://github.com/DarwinAwardWinner/Dist-Zilla-PluginBundle-Author-RTHOMPSON. Then it will apply to all of my perl modules.

Owner

DarwinAwardWinner commented Feb 28, 2016

If this addition to dist.ini is something that should pretty much be in every module, it would probably make more sense to add it to my plugin bundle here: https://github.com/DarwinAwardWinner/Dist-Zilla-PluginBundle-Author-RTHOMPSON. Then it will apply to all of my perl modules.

DarwinAwardWinner added a commit to DarwinAwardWinner/Dist-Zilla-PluginBundle-Author-RTHOMPSON that referenced this pull request Mar 3, 2016

@DarwinAwardWinner

This comment has been minimized.

Show comment
Hide comment
@DarwinAwardWinner

DarwinAwardWinner Mar 3, 2016

Owner

Ok, version 0.160630 will include a provides section in META.yml, thanks to this change in my dzil bundle: DarwinAwardWinner/Dist-Zilla-PluginBundle-Author-RTHOMPSON@d4abfdc

Owner

DarwinAwardWinner commented Mar 3, 2016

Ok, version 0.160630 will include a provides section in META.yml, thanks to this change in my dzil bundle: DarwinAwardWinner/Dist-Zilla-PluginBundle-Author-RTHOMPSON@d4abfdc

@jmaslak

This comment has been minimized.

Show comment
Hide comment
@jmaslak

jmaslak Mar 4, 2016

Thanks - I hadn't gotten around to submitting it yet. :)

On Wed, Mar 2, 2016 at 6:20 PM, Ryan C. Thompson notifications@github.com
wrote:

Ok, version 0.160630 will include a provides section in META.yml, thanks
to this change in my dzil bundle:
DarwinAwardWinner/Dist-Zilla-PluginBundle-Author-RTHOMPSON@d4abfdc
DarwinAwardWinner/Dist-Zilla-PluginBundle-Author-RTHOMPSON@d4abfdc


Reply to this email directly or view it on GitHub
#23 (comment)
.

jmaslak commented Mar 4, 2016

Thanks - I hadn't gotten around to submitting it yet. :)

On Wed, Mar 2, 2016 at 6:20 PM, Ryan C. Thompson notifications@github.com
wrote:

Ok, version 0.160630 will include a provides section in META.yml, thanks
to this change in my dzil bundle:
DarwinAwardWinner/Dist-Zilla-PluginBundle-Author-RTHOMPSON@d4abfdc
DarwinAwardWinner/Dist-Zilla-PluginBundle-Author-RTHOMPSON@d4abfdc


Reply to this email directly or view it on GitHub
#23 (comment)
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment