diff --git a/.circleci/config.yml b/.circleci/config.yml index b43d5c81b0..2f2cb2e0d3 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -49,7 +49,8 @@ commands: build_unit_test_steps: steps: - - browser-tools/install-browser-tools + - browser-tools/install-browser-tools: + chrome-version: "120.0.6099.224" - run: name: Build and run unit tests command: | diff --git a/samples/captioning/events.html b/samples/captioning/events.html index 54abc4175b..5c41b18810 100644 --- a/samples/captioning/events.html +++ b/samples/captioning/events.html @@ -46,10 +46,7 @@ player.updateSettings({ streaming: { text: { - dispatchForManualRendering: true, - webvtt: { - customRenderingEnabled: true - } + dispatchForManualRendering: true } } }) diff --git a/src/streaming/text/TextTracks.js b/src/streaming/text/TextTracks.js index cc7ee393ec..420114167f 100644 --- a/src/streaming/text/TextTracks.js +++ b/src/streaming/text/TextTracks.js @@ -575,6 +575,9 @@ function TextTracks(config) { if (_isHTMLCue(currentItem) && currentCaptionEventCue && currentCaptionEventCue.cueID !== cue.cueID) { _triggerCueExit(currentCaptionEventCue); } + // We need to delete the type attribute to be able to dispatch via th event bus + delete cue.type; + currentCaptionEventCue = cue; _triggerCueEnter(cue); }