From 7b1f0641cd5659a38a294c89dff4f0f7bcb65053 Mon Sep 17 00:00:00 2001 From: Daniel Silhavy Date: Tue, 25 Apr 2023 19:05:12 +0200 Subject: [PATCH] Fix nullpointer if video element is set to null (#4178) --- src/streaming/models/VideoModel.js | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/src/streaming/models/VideoModel.js b/src/streaming/models/VideoModel.js index 172abee8f8..2623294662 100644 --- a/src/streaming/models/VideoModel.js +++ b/src/streaming/models/VideoModel.js @@ -356,13 +356,19 @@ function VideoModel() { } function getVideoRelativeOffsetTop() { - const parentElement = element.parentNode.host || element.parentNode; - return parentElement ? element.getBoundingClientRect().top - parentElement.getBoundingClientRect().top : NaN; + if (element) { + const parentElement = element.parentNode.host || element.parentNode; + return parentElement ? element.getBoundingClientRect().top - parentElement.getBoundingClientRect().top : NaN; + } + return NaN; } function getVideoRelativeOffsetLeft() { - const parentElement = element.parentNode.host || element.parentNode; - return parentElement ? element.getBoundingClientRect().left - parentElement.getBoundingClientRect().left : NaN; + if (element) { + const parentElement = element.parentNode.host || element.parentNode; + return parentElement ? element.getBoundingClientRect().left - parentElement.getBoundingClientRect().left : NaN; + } + return NaN; } function getTextTracks() {