From dcc3bd4b4b2b8cf8247d8af1e08b7b51bad69916 Mon Sep 17 00:00:00 2001 From: Daniel Silhavy Date: Mon, 29 Apr 2024 16:11:37 +0200 Subject: [PATCH] Fix bug in _isCueActive (#4456) --- src/streaming/text/TextTracks.js | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/src/streaming/text/TextTracks.js b/src/streaming/text/TextTracks.js index 2db86d6b4a..28200c44fc 100644 --- a/src/streaming/text/TextTracks.js +++ b/src/streaming/text/TextTracks.js @@ -421,11 +421,15 @@ function TextTracks(config) { previousISDState = renderHTML( cue.isd, finalCue, - function (src) { return _resolveImageSrc(cue, src) }, + function (src) { + return _resolveImageSrc(cue, src) + }, captionContainer.clientHeight, captionContainer.clientWidth, settings.get().streaming.text.imsc.displayForcedOnlyMode, - function (err) { logger.info('renderCaption :', err) /*TODO: add ErrorHandler management*/ }, + function (err) { + logger.info('renderCaption :', err) /*TODO: add ErrorHandler management*/ + }, previousISDState, settings.get().streaming.text.imsc.enableRollUp ); @@ -534,7 +538,8 @@ function TextTracks(config) { * Only do this for imsc subs (where isd is present). */ if (prevCue.isd) { - prevCue.onexit = function () { }; + prevCue.onexit = function () { + }; } // If cues are added when the track is disabled they can still persist in memory if (track.mode !== Constants.TEXT_DISABLED) { @@ -941,7 +946,7 @@ function TextTracks(config) { function _isCueActive(cue) { const currentTime = videoModel.getTime(); - return cue.startTime >= currentTime && cue.endTime <= currentTime + return currentTime >= cue.startTime && currentTime <= cue.endTime } function deleteCuesFromTrackIdx(trackIdx, start, end) {