Image subtitles with layout #1536
Conversation
…s with the video. Limitations: Only handles layout in percent units and extent and origin set on div element. Should instead use the region, and handle pixels.
…element. Takes both % and px values.
…rceBuffer even if states is not 'open' but 'ended'. This is needed to remove all the texttracks and their cues.
|
@AkamaiDASH This starts to get ready and should get into 2.3.0 IMO. Currently, only embedded image subtitles is supported, but both in side-loaded text tracks and fragmented text tracks. I think we should leave remote images for the next release. There is one minor issue showing as one track being repeated if there is more than two tracks. Will try to fix that in the next few days. |
|
@TobbeEdgeware . Great please merge and Ill do a release candidate later today. Then we can do a new RC if you to submit a fix for a known issue or add to the known issue list if not able to fix it. As long as there is no regression in features ;) |
|
@AkamaiDASH I've tested all other subtitle modes and they still work. There is also a fix that cleans fragmentedTracks better on reload in commit 9167255, so fragmentedText will actually work a little better even for text subtitle. Regarding the issue I mentioned above, it was an issue with malformed manifest, so no change need to be done to the code. I'll merge. |
TobbeEdgeware
added
Feature Enhancement
and removed
Work in Progress - Don't Merge
labels
|
@TobbeEdgeware looks great thanks for merging. I will release an RC now. |
Support for embedded image subtitles with positioning and scaling.
The layout support is for
origin and extentin region in units of either % or px. In the latter case, the px are used relative toextentspecified in the<tt>element.There is also support for
origin and extentspecified in the<div>element, which is not according to standard.A test sequence http://vm2.dashif.org/dash/vod/testpic_2s/img_subs.mpd has all three types of layout specified as different tracks.