Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1762 where VTT subtitle positioning was omitted #1791

Merged
merged 1 commit into from
Feb 21, 2017
Merged

Fixes #1762 where VTT subtitle positioning was omitted #1791

merged 1 commit into from
Feb 21, 2017

Conversation

wallstersson
Copy link

Fixes #1762

@TobbeEdgeware TobbeEdgeware self-assigned this Feb 21, 2017
TobbeEdgeware
TobbeEdgeware approved these changes Feb 21, 2017
View reviewed changes
Copy link

@TobbeEdgeware TobbeEdgeware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine.

@TobbeEdgeware TobbeEdgeware merged commit 2a837eb into Dash-Industry-Forum:development Feb 21, 2017
@TobbeEdgeware
Copy link

TobbeEdgeware commented Feb 21, 2017 •
edited
Loading

@wallstersson I missed that your employer is not a member of DASH-IF, so please sign the CLA: https://www.clahub.com/agreements/Dash-Industry-Forum/dash.js

@TobbeEdgeware
Copy link

Sorry @wallstersson. Just saw on the mail group that you had sent in the CLA, so everything is fine. Thanks for the patch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TobbeEdgeware TobbeEdgeware TobbeEdgeware approved these changes

Assignees

@TobbeEdgeware TobbeEdgeware

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wallstersson @TobbeEdgeware