old quality should be reported to droppedFrameHistory onQualityChangeRendered #1989
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertbryer can you please review this? |
robertbryer
suggested changes
Jun 6, 2017
|
I see. During startup we're also pushing playbackIndex === undefined on line 304. I can write a fix to catch both in DroppedFramesHistory.js. By checking isNaN(index) on line 18 both cases can be discarded. This would still update lastDroppedFrames and lastTotalFrames to avoid stale information. Does this make sense? |
robertbryer
approved these changes
Jun 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The outstanding dropped frames statistics in the VideoModel correspond to the old quality.