Don't set initialized flag to false in MediaPlayer.reset() #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@robertbryer you 're right. I did a mistake. After a call to reset, the main app has to call attachView, and attachSource : the stream will start. The only issue is that, in this state, the main app can't call initialize with videoElement and source parameters. It could be interesting to throw, for this special case(after a call to reset, a call to initialize with parameters), an error.... |
dpieri
added a commit
to dpieri/dash.js
that referenced
this pull request
Oct 2, 2017
…d flag to false in MediaPlayer.reset() ) This intended change from Dash-Industry-Forum#2016 was reverted as part of a refactor Dash-Industry-Forum#2007 (Dash-Industry-Forum@3abca12) Dash-Industry-Forum#2016
epiclabsDASH
added a commit
that referenced
this pull request
Oct 3, 2017
Bring back change from #2016 (Don't set initialized flag to false in MediaPlayer.reset() )
siropeich
pushed a commit
to siropeich/dash.js
that referenced
this pull request
Oct 5, 2017
…d flag to false in MediaPlayer.reset() ) This intended change from Dash-Industry-Forum#2016 was reverted as part of a refactor Dash-Industry-Forum#2007 (Dash-Industry-Forum@3abca12) Dash-Industry-Forum#2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's not true that the media player isn't initialised after calling reset() - it's in exactly the same state as calling initialize() with no arguments. It's still in a valid initialized state and possible to call attachView(), attachSource() and playback afterwards.