Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat capability to match lang regex for initial settings #2866



Copy link


We can set a specific initial lang but in some cases (legacy manifest cases), a same audio track could be identified by two different langs.
In our case, our legacy manifests use fr or vf lang where our newest manifests use lv which stands for local version.

On the player side, the goal is to always start with the local language version (even if the user has changed it on a previous video).


This PR adds the capability to match the lang which a regex, in our case /fr|vf|lv/.

That change doesn't introduce a BC on the API, we can still use a classic string to match.

  • Documentation
  • Tests

@dsilhavy dsilhavy added this to the 3.0.2 milestone Jan 20, 2020
@dsilhavy dsilhavy self-requested a review January 20, 2020 11:00
@dsilhavy dsilhavy merged commit 7882e95 into Dash-Industry-Forum:development Jan 20, 2020
Copy link

Merged with additional changes to the unit tests

@valotvince valotvince deleted the feat-match-initial-lang branch May 3, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants