feat capability to match lang regex for initial settings #2866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merged with additional changes to the unit tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
We can set a specific initial lang but in some cases (legacy manifest cases), a same audio track could be identified by two different langs.
In our case, our legacy manifests use
frorvflang where our newest manifests uselvwhich stands for local version.On the player side, the goal is to always start with the local language version (even if the user has changed it on a previous video).
How
This PR adds the capability to match the lang which a regex, in our case
/fr|vf|lv/.That change doesn't introduce a BC on the API, we can still use a classic string to match.