Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix live delay computation #3285

Conversation

@dsilhavy
Copy link
Collaborator

@dsilhavy dsilhavy commented Jun 11, 2020

The goal of this PR is to fix/adjust live delay calculation:

  • Fix live delay calculation for SegmentTimeline manifests for which no valid segment request could be generated with the initial live delay. Increase live delay until a valid segment is found instead of starting playback at the beginning of the DVR window
  • When live delay is different from the value initially calculated by computeLiveDelay it gets adjusted in StreamProcessor.findRequestForLiveEdge -> playbackController.setLiveDelay
  • If the live delay should be a multiple of the fragment duration use @maxSegmentDuration for multiperiod manifests. For single period manifests iterate through the available AdaptationSets and use the largest segment duration.

This PR is supposed to fix #3227 and #3146

Known Issues:
For SegmentTimeline manifests the fragmentDuration is currently NaN. Related to #3284

@dsilhavy dsilhavy added the Bug label Jun 11, 2020
@dsilhavy dsilhavy added this to the 3.1.2 milestone Jun 11, 2020
@dsilhavy dsilhavy merged commit df3e5fb into Dash-Industry-Forum:development Jun 12, 2020
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
commit-workflow Workflow: commit-workflow
Details
@dsilhavy dsilhavy mentioned this pull request Jun 29, 2020
5 of 5 tasks complete
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

1 participant
You can’t perform that action at this time.