Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiperiod representation update #3337

Conversation

@dsilhavy
Copy link
Collaborator

dsilhavy commented Jul 15, 2020

The goal of this PR is to consider multiperiod manifests when updating the representations in the RepresentationController. The update of the Representations is postponed whenever live delay is larger than availwindow.end - availwindow.start.

However, for multiperiod we might still be playing in the previous period when a new period is introduced and the respective RepresentationController updates the representations. Live delay might be too large so we need to consider the currently playing period as starttime anchor: Math.min(availwindow.start,currenttime)

dsilhavy added 2 commits Jul 15, 2020
…he playback controller. This allows us to consider the current playback position for multiperiod streams.
… use playback controller and schedule controller to determine current period
@dsilhavy dsilhavy added this to the 3.1.2 milestone Jul 15, 2020
@dsilhavy dsilhavy merged commit b82c275 into Dash-Industry-Forum:development Jul 16, 2020
2 checks passed
2 checks passed
ci/circleci: build Your tests passed on CircleCI!
Details
commit-workflow Workflow: commit-workflow
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

1 participant
You can’t perform that action at this time.