Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

iPXE binary is commited into the edk2 source repository #198

Closed
macpijan opened this issue Sep 20, 2022 · 1 comment
Closed

iPXE binary is commited into the edk2 source repository #198

macpijan opened this issue Sep 20, 2022 · 1 comment
Assignees
Labels
MSI PRO Z690-A boards novacustom_ns5x/7x_tgl NovaCustom NS5x/7xMU (11th Gen) novacustom_ns7x_tgl NovaCustom NS7xMU (11th Gen) novacustom_nv4x_tgl NovaCustom NV4xMx (11th Gen) protectli_vault_cml VP 4xxx protectli_vault_glk VP 2410 tuxedo_ibs15

Comments

@macpijan
Copy link
Contributor

Dasharo version

All (eg. v1.2.1)

Dasharo variant

All (e.g. NovaCustom NV4x)

Affected component(s) or functionality

UEFI payload (edk2)

Brief summary

ipxe is commited as a binary blob, while we should use source code instead

How reproducible

100%

How to reproduce

Steps to reproduce the behavior:

  1. There is a binary commited here: https://github.com/Dasharo/edk2/blob/dasharo/UefiPayloadPkg/NetworkDrivers/ipxe.efi

Expected behavior

  1. A binary (build result) is not part of the repository. Instead, the repository contains
    the necessary build infrastructure to buid the requied ipxe binary from source code.

Actual behavior

There is a binary commited here: https://github.com/Dasharo/edk2/blob/dasharo/UefiPayloadPkg/NetworkDrivers/ipxe.efi

Screenshots

N/A

Additional context

Solutions you've tried

Some idea of mine was here - to at least ship some script to explain how
the given iPXE binary was built: Dasharo/edk2#13

Shipping iPXE binary with zero information on how it was built (and using
which source code base) is totally unacceptable.

@macpijan macpijan added novacustom_nv4x_tgl NovaCustom NV4xMx (11th Gen) novacustom_ns5x/7x_tgl NovaCustom NS5x/7xMU (11th Gen) protectli_vault_glk VP 2410 protectli_vault_cml VP 4xxx novacustom_ns7x_tgl NovaCustom NS7xMU (11th Gen) tuxedo_ibs15 MSI PRO Z690-A boards labels Sep 20, 2022
@miczyg1
Copy link
Contributor

miczyg1 commented Jan 26, 2023

Resolved with Dasharo/edk2#34

@miczyg1 miczyg1 closed this as completed Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
MSI PRO Z690-A boards novacustom_ns5x/7x_tgl NovaCustom NS5x/7xMU (11th Gen) novacustom_ns7x_tgl NovaCustom NS7xMU (11th Gen) novacustom_nv4x_tgl NovaCustom NV4xMx (11th Gen) protectli_vault_cml VP 4xxx protectli_vault_glk VP 2410 tuxedo_ibs15
Projects
None yet
Development

No branches or pull requests

3 participants