Skip to content

reports: Add psptool to hcl report #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 9, 2025
Merged

reports: Add psptool to hcl report #118

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
35c926c
reports: Add psptool to hcl report
3mkusiak Oct 8, 2025
00b0601
reports: psptool: add fixme
3mkusiak Oct 8, 2025
38b7991
reports: store FW dump path in var
3mkusiak Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
33 changes: 30 additions & 3 deletions reports/dasharo-hcl-report.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,11 @@ source $DTS_HAL

# Vars for controlling progress bar
progress_bar_cntr=0
PROGRESS_BAR_TASKS_TOTAL=27
PROGRESS_BAR_TASKS_TOTAL=28

# Helper vars
FW_DUMP_DEFAULT_PATH="logs/rom.bin"
fw_bin_path="$FW_DUMP_DEFAULT_PATH"

progress_bar_update() {
local BAR_WIDTH=67
Expand Down Expand Up @@ -64,7 +68,7 @@ update_result() {
fi
# specific check for firmware dump
if [ $LOGFILE == "logs/flashrom_read.log" ]; then
if [ $LOG -ne 0 ] && [ -f "logs/rom.bin" ]; then
if [ $LOG -ne 0 ] && [ -f "$FW_DUMP_DEFAULT_PATH" ]; then
echo -e [$GREEN"OK"$NORMAL]"\t\t"$TOOL >>result
else
echo -e [$RED"ERROR"$NORMAL]"\t\t"$TOOL >>result
Expand Down Expand Up @@ -228,7 +232,7 @@ if [ "${SYSTEM_VENDOR}" != "QEMU" ] && [ "${SYSTEM_VENDOR}" != "Emulation" ]; th
FLASHROM_ADD_OPT_READ=""
fi

$FLASHROM -V -p internal:laptop=force_I_want_a_brick ${FLASH_CHIP_SELECT} -r logs/rom.bin ${FLASHROM_ADD_OPT_READ} >logs/flashrom_read.log 2>logs/flashrom_read.err.log
$FLASHROM -V -p internal:laptop=force_I_want_a_brick ${FLASH_CHIP_SELECT} -r "${FW_DUMP_DEFAULT_PATH}" ${FLASHROM_ADD_OPT_READ} >logs/flashrom_read.log 2>logs/flashrom_read.err.log
if [ $? -ne 0 ]; then
clear_line
print_error 'CRITICAL ERROR: cannot dump firmware!'
Expand All @@ -238,6 +242,29 @@ fi
## Update progress bar anyway
progress_bar_update

# Run psptool on dumped or external firmware
if [ ! -f "$fw_bin_path" ] && [ -d "/firmware/external" ]; then
count=$(ls -1A /firmware/external | wc -l)

if [ "$count" -eq 1 ]; then
clear_line
print_warning "Firmware dump not found, but found user-supplied external binary."
fw_bin_path="/firmware/external/$(ls -1A /firmware/external)"
elif [ "$count" -gt 1 ]; then
clear_line
print_error "Multiple files found in /firmware/external! Make sure only a single file is present!"
fi
fi
psptool -E "$fw_bin_path" >>logs/psptool.log 2>>logs/psptool.err.log
# FIXME: The following will always result in UNKNOWN
# There are two reasons for this:
# * The tool always returns 0, even if binary is for intel or just all zeros.
# * The warnings are redirected to stderr, running on "bad" binaries will just
# print warnings, not errors.
# This needs to be fixed at tool level.
update_result "PSPTool" logs/psptool.err.log
progress_bar_update

# echo "Probing all I2C buses..."
MAX_I2C_ID=$(i2cdetect -l | awk 'BEGIN{c1=0} //{c1++} END{print "",--c1}')
for bus in $(seq 0 "$MAX_I2C_ID"); do
Expand Down