This repository has been archived by the owner on Apr 12, 2021. It is now read-only.
feat(functions): #1589 added PullRequestReviewCommentEvent #1591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… response event type
eddiejaoude
reviewed
Jan 3, 2020
functions/src/mappers/github/webhook-event-response/pull-request-review-comment.ts
Show resolved
Hide resolved
eddiejaoude
reviewed
Feb 1, 2020
|
|
||
| switch (this.action) { | ||
| case 'created': | ||
| { |
There was a problem hiding this comment.
{ not needed in the switch statement
eddiejaoude
reviewed
Feb 1, 2020
| } | ||
|
|
||
| private updated(repository: DocumentData, number: number): void { | ||
| const foundIndex: number = repository.pullRequests.findIndex((elem: GitHubPullRequestModel) => elem.uid === this.pull_request.id); |
There was a problem hiding this comment.
This can be done with es6
eddiejaoude
reviewed
Feb 1, 2020
| export class PullRequestReviewCommentEventModel implements PullRequestReviewCommentEventInput { | ||
| action: Action; | ||
| comment: Comment; | ||
| pull_request: PullRequest; |
There was a problem hiding this comment.
We use camelcase in our models
eddiejaoude
reviewed
Feb 1, 2020
| node_id: number; | ||
| diff_hunk: string; | ||
| path: User; | ||
| postition: string; |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1589
Notes
A summary of what was achieved in this PR