Make the build reproducible #2563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0], we noticed that toil could not be built reproducibly. This is due to the documentation embedding the year when the software was built. This was originally filed in Debian as #925191 [1]. [0] https://reproducible-builds.org/ [1] https://bugs.debian.org/925191 Signed-off-by: Chris Lamb <lamby@debian.org>
mr-c
approved these changes
Mar 21, 2019
|
Heh, somehow I was too slow! |
ghost
assigned 
|
@lamby no worries! I'm keeping this PR and will merge soon |
|
How come? You merged #2562 so this issue is no longer present...? |
|
#2562 is closed, not merged |
|
Doh, I can't read. Please merge this one then ;-) |
|
@mr-c To get the new Gitlab CI to run on PRs from forks, we have to pull the commits into the main DataBiosphere/toil repo on some branch. I've just done that for this PR: If everyone who reviews does that after they approve, we can get CI run in a reasonably timely manner. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Whilst working on the Reproducible Builds effort, we noticed that toil could not be built reproducibly. This is due to the documentation embedding the year when the software was built.
(This was originally filed in Debian as #925191)