Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the build reproducible #2563

Merged
merged 1 commit into from Mar 22, 2019

Conversation

Projects
None yet
3 participants
@lamby
Copy link
Contributor

commented Mar 21, 2019

Whilst working on the Reproducible Builds effort, we noticed that toil could not be built reproducibly. This is due to the documentation embedding the year when the software was built.

(This was originally filed in Debian as #925191)

Make the build reproducible
Whilst working on the Reproducible Builds effort [0], we noticed
that toil could not be built reproducibly.

This is due to the documentation embedding the year when the software was
built.

This was originally filed in Debian as #925191 [1].

 [0] https://reproducible-builds.org/
 [1] https://bugs.debian.org/925191

Signed-off-by: Chris Lamb <lamby@debian.org>

@mr-c mr-c referenced this pull request Mar 21, 2019

Closed

Make the build reproducible #2562

@mr-c

mr-c approved these changes Mar 21, 2019

@lamby

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

Heh, somehow I was too slow!

@lamby lamby closed this Mar 21, 2019

@mr-c mr-c reopened this Mar 21, 2019

@wafflebot wafflebot bot assigned mr-c Mar 21, 2019

@wafflebot wafflebot bot added the in progress label Mar 21, 2019

@mr-c

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@lamby no worries! I'm keeping this PR and will merge soon

@lamby

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

How come? You merged #2562 so this issue is no longer present...?

@mr-c

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

#2562 is closed, not merged 😬

@lamby

This comment has been minimized.

Copy link
Contributor Author

commented Mar 21, 2019

Doh, I can't read. Please merge this one then ;-)

@adamnovak

This comment has been minimized.

Copy link
Contributor

commented Mar 21, 2019

@mr-c To get the new Gitlab CI to run on PRs from forks, we have to pull the commits into the main DataBiosphere/toil repo on some branch. I've just done that for this PR:

git fetch git@github.com:lamby/toil.git 925191-toil-please-make-the-build-reproducible
git push upstream FETCH_HEAD:refs/heads/issues/2563-make-the-build-reproducible

If everyone who reviews does that after they approve, we can get CI run in a reasonably timely manner.

@mr-c mr-c merged commit c9768b1 into DataBiosphere:master Mar 22, 2019

1 of 2 checks passed

ci/gitlab/ucsc-ci.com Pipeline running on GitLab
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@wafflebot wafflebot bot removed the in progress label Mar 22, 2019

@lamby lamby deleted the lamby:925191-toil-please-make-the-build-reproducible branch Mar 28, 2019

@lamby lamby restored the lamby:925191-toil-please-make-the-build-reproducible branch Mar 28, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.