Skip to content

Avoid failing when res['invocation'] has no module_name key #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2016
Merged

Avoid failing when res['invocation'] has no module_name key #19

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions datadog_callback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,37 +156,39 @@ def format_result(res):
event_text = msg
else:
invocation = res['invocation']
event_text = "$$$\n{0}[{1}]\n$$$\n".format(invocation['module_name'], invocation.get('module_args', ''))
module_name = invocation.get('module_name', 'undefined')
event_text = "$$$\n{0}[{1}]\n$$$\n".format(module_name, invocation.get('module_args', ''))
event_text += msg
module_name = 'module:{0}'.format(invocation['module_name'])
if 'module_stdout' in res:
# On Ansible v2, details on internal failures of modules are not reported in the `msg`,
# so we have to extract the info differently
event_text += "$$$\n{0}\n{1}\n$$$\n".format(
res.get('module_stdout', ''), res.get('module_stderr', ''))

return event_text, module_name
module_name_tag = 'module:{0}'.format(module_name)

return event_text, module_name_tag

### Ansible callbacks ###
def runner_on_failed(self, host, res, ignore_errors=False):
event_text, module_name = self.format_result(res)
event_text, module_name_tag = self.format_result(res)
self.send_task_event(
'Ansible task failed on "{0}"'.format(host),
alert_type='error',
text=event_text,
tags=[module_name],
tags=[module_name_tag],
host=host,
)

def runner_on_ok(self, host, res):
# Only send an event when the task has changed on the host
if res.get('changed'):
event_text, module_name = self.format_result(res)
event_text, module_name_tag = self.format_result(res)
self.send_task_event(
'Ansible task changed on "{0}"'.format(host),
alert_type='success',
text=event_text,
tags=[module_name],
tags=[module_name_tag],
host=host,
)

Expand Down