Fix KeyError on res argument passed to runner_on_ok
#3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use a more conservative approach as to the existence of the `changed` key. This could be extended to all the keys that are used on dicts passed to the callback (as afaik Ansible doesn't provide any guarantee of their existence), but for now a case-by-case approach may be enough.
olivielpeau
added a commit
that referenced
this pull request
Oct 1, 2015
…rror Fix KeyError on `res` argument passed to `runner_on_ok`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use a more conservative approach as to the existence of the
changedkey.
This could be extended to all the keys that are used on dicts passed
to the callback (as afaik Ansible doesn't provide any guarantee of their
existence), but for now a case-by-case approach may be enough.