System-probe indent filter fix #240
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albertvaka
approved these changes
Dec 19, 2019
KSerrania
added a commit
that referenced
this pull request
Dec 23, 2019
Replaces the first argument of the indent filter with the older indentfirst. The first option is only supported by jinja 2.10+ which is not present on older systems (CentOS 7, Debian 8, etc.).
KSerrania
added a commit
that referenced
this pull request
Dec 23, 2019
Replaces the first argument of the indent filter with the older indentfirst. The first option is only supported by jinja 2.10+ which is not present on older systems (CentOS 7, Debian 8, etc.).
|
@KSerrania a heads up that https://github.com/pallets/jinja/blob/2.11.x/src/jinja2/filters.py#L633 |
tasktop-teho
added a commit
to tasktop-teho/ansible-datadog
that referenced
this pull request
May 17, 2021
* This is a revert of DataDog#240
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Replaces the
firstargument of theindentfilter with the olderindentfirst.Fixes #229.
Motivation
The
firstoption is only supported by jinja 2.10+ which is not present on older systems (CentOS 7, Debian 8, etc.).Using the equivalent option
indentfirst(see here) will work with all currently existing jinja 2 versions (as of this comment, up to 2.10).