DOCS-630 Ansible docs #270
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSerrania
reviewed
Apr 6, 2020
Contributor
KSerrania
left a comment
KSerrania
left a comment
There was a problem hiding this comment.
LGTM overall, made some suggestions to change outdated / wrong details
KSerrania
reviewed
Apr 6, 2020
Co-Authored-By: Kylian Serrania <kylian.serrania@datadoghq.com>
cswatt
reviewed
Apr 7, 2020
Contributor
|
Hey @ruthnaebeck, is this ready to merge? I'd like to release a new version of the role today or tomorrow. |
cswatt
reviewed
Apr 7, 2020
cswatt
reviewed
Apr 7, 2020
cswatt
reviewed
Apr 7, 2020
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
Contributor
Author
|
@KSerrania - ready to go. Just a few wording fixes. |
cswatt
reviewed
Apr 7, 2020
cswatt
reviewed
Apr 7, 2020
cswatt
reviewed
Apr 7, 2020
cswatt
reviewed
Apr 7, 2020
cswatt
reviewed
Apr 7, 2020
cswatt
reviewed
Apr 7, 2020
cswatt
reviewed
Apr 7, 2020
cswatt
reviewed
Apr 7, 2020
cswatt
approved these changes
Apr 7, 2020
Co-Authored-By: cswatt <cecilia.watt@datadoghq.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
OKR - To have the README pull into the public docs site.
Preview link
N/A