Add default values when variables are defined but nil #303
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julien-lebot
reviewed
Oct 2, 2020
tasks/pkg-windows-opts.yml
Outdated
| set_fact: | ||
| win_install_args: "{{ win_install_args }} DDAGENTUSER_NAME={{ datadog_windows_ddagentuser_name }}" | ||
| when: datadog_windows_ddagentuser_name | length > 0 | ||
| when: datadog_windows_ddagentuser_name | | default('', true) | length > 0 |
Contributor
There was a problem hiding this comment.
There's two consecutive | on this line, is that on purpose ?
Contributor
Author
There was a problem hiding this comment.
That's a typo indeed 😄
julien-lebot
approved these changes
Oct 2, 2020
Contributor
julien-lebot
left a comment
julien-lebot
left a comment
There was a problem hiding this comment.
I'm not familiar with Ansible but those changes LGTM !
derekwbrown
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds guards when trying to read variable lengths, to avoid reading the length of
null, which results in a crash.Motivation
It is possible to get into situations where a variable is set, but has a
nullvalue (eg. by addingkey:in the yaml vars). If we check the length of such a variable (which should thus be a list, string or dictionary), we should first default to a reasonable value if a null value is given.defaultneeds to be used withboolean=Trueto also match falsey values (such asnull), otherwise it only matches undefined variables.