Update linter and fix issues found #340
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It never (testesd in 2.6 and 2.10) worked: wildcards aren't expanded
KSerrania
reviewed
Mar 29, 2021
Contributor
KSerrania
left a comment
KSerrania
left a comment
There was a problem hiding this comment.
LGTM.
About the file permissions: we're already making the Agent 6/7 main config file not world-readable. Should we do the same for the integrations config files, the config dir itself? And should we do the same for the Agent 5 config too?
albertvaka
commented
Mar 29, 2021
Contributor
Author
|
I've just added a FIXME for A5, the same way I added a FIXME for Windows in the original changes. Those are breaking changes so they will have to wait until a new major version. The Windows one is a bit more worrying than A5. About the directories themselves, I don't think it's a security issue that they are accessible by anyone. |
KSerrania
approved these changes
Mar 30, 2021
bkabrda
approved these changes
Mar 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps the linter docker image and fixes the following warnings:
role_nameandnamespacemissing from metadata.