Check datadog_checks to avoid misconfiguration
#384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bkabrda
reviewed
Aug 26, 2021
Contributor
bkabrda
left a comment
bkabrda
left a comment
There was a problem hiding this comment.
Hey 👋 thanks a lot for the PR. It looks good, I just suggested a small change that would ensure the name of the task is a little bit more descriptive. If that looks good to you, let's get it applied and merged.
Co-authored-by: Slavek Kabrda <slavek.kabrda@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A misconfiguration like:
leads to looping over a string and creating a lot of directories in
/etc/datadog-agent/conf.d/. I propose to add a check for this.