Skip to content

[ansible] Ensure user/group selected for macOS systemwide installation actually exist #479

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pythyu merged 6 commits into from
Apr 6, 2023
Merged

[ansible] Ensure user/group selected for macOS systemwide installation actually exist #479

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5ac09e7
feat(macOS): check if user and group exists
Pythyu Apr 4, 2023
9913ab2
update(pkg-macros): fix previous errors + rework group handling
Pythyu Apr 4, 2023
aa154a3
fix(pkg-macos): fix no-changed-when linter issues
Pythyu Apr 4, 2023
c4914ad
useless(pkg-macos): removed group check
Pythyu Apr 6, 2023
0802bf1
Update tasks/pkg-macos.yml
Pythyu Apr 6, 2023
3e28899
Update tasks/pkg-macos.yml
Pythyu Apr 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions tasks/pkg-macos.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,17 @@
msg: "The Datadog ansible role does not currently support Agent 5 on macOS"
when: datadog_agent_major_version|int == 5

- name: Check if the macOS user for Agent service exists
command: id -u "{{ datadog_macos_user }}"
register: mac_user_check
changed_when: false
ignore_errors: true

- name: Fail if the macOS user for Agent service doesn't exist
fail:
msg: "The Datadog ansible role wasn't able to find the user : {{ datadog_macos_user }}"
when: mac_user_check.rc != 0

- include_tasks: pkg-macos/macos_agent_latest.yml
when: (not datadog_skip_install) and (datadog_agent_macos_version is not defined)

Expand Down