Fail early when the API key is missing [AP-2380] #512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chouquette
force-pushed
the
chouquette/fail_without_api_key
branch
from
bba5145 to
644f2d2
Compare
Contributor
spencergilbert
left a comment
spencergilbert
left a comment
There was a problem hiding this comment.
Does this need a CHANGELOG addition?
Contributor
Author
I agree, but I think we update the changelog when releasing, for this repo at least. I suppose we don't really know what the next version will be at this point which is why we wait? |
spencergilbert
approved these changes
Aug 23, 2023
Contributor
spencergilbert
left a comment
spencergilbert
left a comment
There was a problem hiding this comment.
Gotcha, I'm used to updating a changelog with "unreleased" as the changes come in. Whatever the standard is works 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.