🐛 remove readonly from all LogsEvent properties

[kotarella1110]

Motivation

In some cases, I want to update the readonly LogsEvent properties by using beforeSend.

resolve #1195

Changes

remove readonly from LogsEvent all properties.

Testing

• Local
• Staging
• Unit
• End to end

---

I have gone over the contributing documentation.

[bits-bot]

All committers have signed the CLA.

[bcaudan]

Hello @kotarella1110,

Thanks for this PR!
Actually, you could even remove all readonly from logsEvent properties to avoid similar issues to be raised.

readonly modifiers were introduced when only a handful of properties was editable, cf #644.
However, we decided to allow users to do what they want with log events in #909 but without updating types accordingly.

[kotarella1110]

Actually, you could even remove all readonly from logsEvent properties to avoid similar issues to be raised.

@bcaudan I see. will do 👍🏻

[kotarella1110]

@bcaudan I think we should avoid updating the following properties, so it is better to leave the readonly property as it is.

• date
• application_id
• service
• session_id
• view.id

Please let me know what you think.

[bcaudan]

I think we should avoid updating the following properties

it is already possible in javascript, so I would say no reason to have the limitation only in typescript.

[kotarella1110]

it is already possible in javascript, so I would say no reason to have the limitation only in typescript.

Thank for your reply! I will fix.

[kotarella1110]

@bcaudan Removed readonly from all properties. Please review 🙏🏻

[BenoitZugmeyer]

Thank you for your contribution! I'll make a new release shortly.