Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jmx yaml recipe doesn't list attributes correctly #116

Closed
celenechang opened this Issue Apr 24, 2014 · 2 comments

Comments

Projects
None yet
3 participants
@celenechang
Copy link

celenechang commented Apr 24, 2014

These lines:

https://github.com/DataDog/chef-datadog/blob/master/templates/default/jmx.yaml.erb#L19-L24

result in attributes attribute0, attribute1, etc. instead of the attribute name

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Apr 27, 2014

@celenechang It's true, they absolutely do that.
Can you provide more context on what someone would expect? A sample jmx.yaml file with the structure (anonymize the attribute names if they seem private) would be helpful.
I think the alias field ends up being the metric name reported in any case.

@remh

This comment has been minimized.

Copy link
Member

remh commented Apr 27, 2014

@miketheman
Instead of attribute0, attribute1, it should be the attribute name as exposed by JMX.
Here is an extract of a configuration:

conf:
    - include:
        attribute:
          maxThreads:
            alias: tomcat.threads.max
            metric_type: gauge
          currentThreadCount:
            alias: tomcat.threads.count
            metric_type: gauge
          bytesReceived:
            alias: tomcat.bytes_rcvd
            metric_type: counter

So it can be any value.

Sorry, i agree that the example file in the dd-agent repo is a bit misleading.
Let me know if you need more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.