Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting up codescanning for chef-datadog #834

Merged
merged 2 commits into from Jan 7, 2022

Conversation

ganeshkumarsv
Copy link
Contributor

@ganeshkumarsv ganeshkumarsv commented Jan 3, 2022

Static code analysis on chef-datadog using Github's Code Scanning.

This PR has Github workflow configs to trigger the Code Scanning on every PR and on push to main branch. As of now only default security based CodeQL queries are configured. We can gradually add queries for Code Quality later. It is a part of Datadog compliance requirements to regularly perform code-scanning on all the customer installed code. As the repository is small, no security alerts were found during the scan.

@ganeshkumarsv ganeshkumarsv requested a review from a team as a code owner January 3, 2022 22:24
Copy link
Contributor

@albertvaka albertvaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I assume since no check is specified, this only checks for security issues, right? What other things can we check for?

@ganeshkumarsv
Copy link
Contributor Author

@albertvaka By default, security queries will be analyzed. We can also scan for code-quality queries. These queries are marked with specific tags and thus they can be grouped with query selectors.

@ganeshkumarsv
Copy link
Contributor Author

ganeshkumarsv commented Jan 6, 2022

As of now code-scanning for Ruby is under Beta-Testing. We hope we they'll add some improvements to the queries in future. You can check the list of security queries that are analyzed from this GitHub action job log: https://github.com/ganeshkumarsv/chef-datadog/runs/4696045050?check_suite_focus=true

@albertvaka albertvaka merged commit bf30100 into DataDog:main Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants