Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support optional datadog events for haproxy check #103

Merged

Conversation

Projects
None yet
4 participants
@evan2645
Copy link
Contributor

evan2645 commented Feb 25, 2014

The haproxy check that ships with datadog agent can optionally create events. That option is not currently supported in the yaml config shipped by chef-datadog; let's make it so.

@miketheman miketheman added this to the Next minor milestone Feb 25, 2014

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Feb 25, 2014

@evan2645 Looks good, will add to the next round of fixes. Thanks!

@remh

This comment has been minimized.

Copy link
Member

remh commented Feb 25, 2014

Hi @evan2645
Thanks for your PR!

This feature is currently disabled as it was a too spammy feature to be useful.

There is a metric that exists that you can enable to get the status of of your backends:

https://github.com/DataDog/dd-agent/blob/master/conf.d/haproxy.yaml.example#L9

You should probably use that instead.
Remi

miketheman added a commit that referenced this pull request Mar 20, 2014

@miketheman miketheman merged commit 8bec004 into DataDog:master Mar 20, 2014

1 check failed

default The Travis CI build failed
Details
@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Mar 20, 2014

Hi @evan2645,
Thanks for this, and got around to adding a couple of other flags - changed it to allow arbitrary values.
This will go in the next release.
Thanks!

n1koo pushed a commit to Shopify/chef-datadog that referenced this pull request Oct 20, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.