Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kafka recipe #113

Merged
merged 8 commits into from Apr 3, 2014

Conversation

Projects
None yet
3 participants
@QuentinFra
Copy link
Member

QuentinFra commented Apr 2, 2014

Adding recipes for kafka and kafka.consumer checks. Tested locally with Kitchen tests

Quentin Francois added some commits Mar 27, 2014

Quentin Francois
Quentin Francois
is_jmx: true

# Metrics collected by this check. You should not have to modify this.
conf:

This comment has been minimized.

Copy link
@miketheman

miketheman Apr 2, 2014

Collaborator

This file mixes 2-space with 4-space.
YAML is already hard enough to get right with one or the other, let's not mix them in the same file.
We use 2-space everywhere else in this cookbook.

This comment has been minimized.

Copy link
@QuentinFra

QuentinFra Apr 2, 2014

Author Member

Ah ok, let me correct that immediately

@clofresh

This comment has been minimized.

Copy link
Contributor

clofresh commented Apr 2, 2014

You should commit the kitchen tests too so that people can run them themselves if they need to make changes to the recipe

Quentin Francois
@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Apr 3, 2014

The test suite is there, not any tests.

@QuentinFra

This comment has been minimized.

Copy link
Member Author

QuentinFra commented Apr 3, 2014

There are only test suites (that's what Carlo was talking about).

Quentin

On Wed, Apr 2, 2014 at 8:23 PM, Mike Fiedler notifications@github.comwrote:

The test suite is there, not any tests.

Reply to this email directly or view it on GitHubhttps://github.com//pull/113#issuecomment-39400223
.

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Apr 3, 2014

The suites will spin up, deploy the code, but make no assertions about the validity of the state - those tests match the suite name under the test/ directory.

@QuentinFra

This comment has been minimized.

Copy link
Member Author

QuentinFra commented Apr 3, 2014

I just wanted to test that there was no coding error in the recipes I made,
so the test suites were good for that.
For the configuration itself, I tested it manually. Isn't that enough? I
don't see many tests for the other integrations...

Quentin

On Thu, Apr 3, 2014 at 10:08 AM, Mike Fiedler notifications@github.comwrote:

The suites will spin up, deploy the code, but make no assertions about the
validity of the state - those tests match the suite name under the test/directory.

Reply to this email directly or view it on GitHubhttps://github.com//pull/113#issuecomment-39454964
.

QuentinFra pushed a commit that referenced this pull request Apr 3, 2014

Quentin Francois

@QuentinFra QuentinFra merged commit b0a0f4d into master Apr 3, 2014

1 check passed

continuous-integration/travis-ci The Travis CI build passed
Details

@miketheman miketheman deleted the kafka-recipe branch Apr 8, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.