Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a few more Elasticsearch integration options #169

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
3 participants
@chrissnell
Copy link
Contributor

chrissnell commented Jan 2, 2015

Adds support for is_external, username, password, and tags.

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Jan 2, 2015

Looks good! There's a one-space off in the tags section around the if/end statements - can you fix that?

@chrissnell

This comment has been minimized.

Copy link
Contributor Author

chrissnell commented Jan 2, 2015

Hi @miketheman , does this new commit fix what you're talking about?

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Jan 2, 2015

@chrissnell no, I was referring to the 3-spaces on the if/end - it should be 2 - lines 15 & 17

@chrissnell

This comment has been minimized.

Copy link
Contributor Author

chrissnell commented Jan 2, 2015

Ahh, I see now. Better?

@chrissnell

This comment has been minimized.

Copy link
Contributor Author

chrissnell commented Jan 2, 2015

OK, I added a space to make it a three-space to match the rest of the spacing in the template. If you want two-space everywhere, LMK and I will change everything to match.

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Jan 2, 2015

I think mentioned that it should be 2 in my prior comment: #169 (comment)

This is how I would expect to see the tags block indented:

    <% if i.key?('tags') -%>
    tags:
      <% i['tags'].each do |t| -%>
      - <%= t %>
      <% end -%>
    <% end -%>

3-spacing is a very odd one - that why I pointed it out. 2-spacing is pretty standard Ruby and YAML.

Would you mind rebasing and squashing these commits down to a single one?

Add support for a few more Elasticsearch integration options
Adds support for is_external, username, password, and tags.
@chrissnell

This comment has been minimized.

Copy link
Contributor Author

chrissnell commented Jan 2, 2015

\o/

@miketheman miketheman added the feature label Jan 2, 2015

@miketheman miketheman added this to the Next minor milestone Jan 2, 2015

@miketheman miketheman self-assigned this Jan 2, 2015

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Jan 2, 2015

Nice! I'll merge this soon with the next round of enhancements.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 28, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 80a518c on chrissnell:master into 6f29a4c on DataDog:master.

miketheman added a commit that referenced this pull request Feb 27, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.