Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add recipes for http_check and tcp_check #177

Closed
wants to merge 4 commits into from

Conversation

Projects
None yet
3 participants
@mtougeron
Copy link
Contributor

mtougeron commented Jan 28, 2015

Add a recipe for http_check and tcp_check to fill out the respective templates. This addresses issue #110

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 28, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling a6d734e on mtougeron:issue-110-refactor into 6f29a4c on DataDog:master.

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Jan 28, 2015

@mtougeron thanks for continuing to work through this.

In #153 (comment) I mentioned that we no longer support the @notify syntax - I've been digging, trying to find a warning message to link to, but that hasn't been produced client-side yet.

Also, as I was writing this, #178 popped up.
I think the combination of these two styles is what I was going for.

@mtougeron

This comment has been minimized.

Copy link
Contributor Author

mtougeron commented Jan 28, 2015

ack, sorry about missing #153#issuecomment-68599421 fixing it now

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 28, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling a843c73 on mtougeron:issue-110-refactor into 6f29a4c on DataDog:master.

@mtougeron

This comment has been minimized.

Copy link
Contributor Author

mtougeron commented Feb 2, 2015

@miketheman do you know which route you want to go with this PR vs #178 & #179? I need to make a similar set of changes for the 'process' check/template.

@mtougeron

This comment has been minimized.

Copy link
Contributor Author

mtougeron commented Feb 24, 2015

@miketheman Any updates on this & PR #181? I just don't want to end up in a situation again where I have to refactor a 4th time due to changes on your end. :) Thanks.

@mtougeron

This comment has been minimized.

Copy link
Contributor Author

mtougeron commented Mar 3, 2015

@miketheman ping? any update on this?

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Mar 3, 2015

@mtougeron sorry for the delay. I've scheduled a time on my calendar for tomorrow to actively work on this particular branch and pull. I might do some rebasing and such.

@mtougeron

This comment has been minimized.

Copy link
Contributor Author

mtougeron commented Mar 3, 2015

Thanks. No worries about the delay, I just didn't want to have to redo it a 3rd time. :)

@mtougeron

This comment has been minimized.

Copy link
Contributor Author

mtougeron commented Mar 24, 2015

@miketheman any update on this? I'd really like to see this and PR #181 included so that I don't have to maintain a forked version of this cookbook. Thanks, Mike

@mtougeron

This comment has been minimized.

Copy link
Contributor Author

mtougeron commented Mar 31, 2015

@miketheman any update on this? Thanks, Mike

@mtougeron

This comment has been minimized.

Copy link
Contributor Author

mtougeron commented Apr 2, 2015

Pushed an update to the .kitchen.yml to resolve conflicts from a recent merge

@miketheman miketheman added the feature label Apr 5, 2015

@miketheman miketheman closed this in a39bb96 Apr 7, 2015

miketheman added a commit that referenced this pull request Apr 7, 2015

tcp_check template
Refs #110, Refs #177

Signed-off-by: Mike Fiedler <miketheman@gmail.com>
@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Apr 7, 2015

Thanks for bearing with me! I rebased a bit and used the new template structure, but we're finally merged to master with the new recipes.

@mtougeron

This comment has been minimized.

Copy link
Contributor Author

mtougeron commented Apr 7, 2015

Thanks!

miketheman added a commit that referenced this pull request Apr 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.