Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New http_check recipe+template #178

Closed
wants to merge 2 commits into from

Conversation

Projects
None yet
4 participants
@chrissnell
Copy link
Contributor

chrissnell commented Jan 28, 2015

A new recipe and template for http_check. Template uses the Ruby->JSON->YAML data structure conversion a la the JMX check recipe.

@coveralls

This comment has been minimized.

Copy link

coveralls commented Jan 28, 2015

Coverage Status

Coverage remained the same at 100.0% when pulling 527372d on chrissnell:http_check into 6f29a4c on DataDog:master.

@chrissnell

This comment has been minimized.

Copy link
Contributor Author

chrissnell commented Jan 28, 2015

Fixed the Travis build error.

@chrissnell

This comment has been minimized.

Copy link
Contributor Author

chrissnell commented Jan 28, 2015

@miketheman I much prefer your new style of YAML building using the Ruby data structure. If the PR from @mtougeron is what you want to roll with, you won't hurt my feelings but we (Revinate) definitely love your new style of config and would prefer to use it.

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Jan 28, 2015

@chrissnell I'm a big fan as well - as you can see, there's a comment on that one.

I guess "whomever can get the code & tests into place first" wins? /cc: @mtougeron

@mtougeron

This comment has been minimized.

Copy link
Contributor

mtougeron commented Jan 28, 2015

ready... set... race!! haha. but in all seriousness, I'm updating PR 177 now.

@chrissnell

This comment has been minimized.

Copy link
Contributor Author

chrissnell commented Jan 28, 2015

You want TESTS? I think @mtougeron is going to win this one. :)

@miketheman miketheman added the feature label Apr 5, 2015

@miketheman miketheman closed this in 95265a6 Apr 7, 2015

@miketheman

This comment has been minimized.

Copy link
Collaborator

miketheman commented Apr 7, 2015

Thanks for bearing with me - I rebased and reordered a touch, but we're not merged to master along with the other changesets.

miketheman added a commit that referenced this pull request Apr 7, 2015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.